Skip to content

Project 4 Code Review

Practice!

I recommend walking through the following on your own prior to turning in your project. Do this as many times as you need to become comfortable walking through your code and staying within the time-limit. Often by going through this process you find corrections or things that can be improved upon.

Code Review Process

Take Notes!

You are expected to take notes during the code review to capture any feedback the instructor may give. A document has been provided for you: screenshots/project4/code-review-notes.

Part 1: Code Walkthrough

  1. Demonstrate the add and search functionality in the browser:

    1. Starting at the home page, navigate to the add employee form.

    2. Demonstrate the validation you have implemented for the “add” scenario.

    3. Demonstrate a successful Add, including the ‘successful add’ message.

    4. Navigate to the home page and return to the add page to demonstrate that the ‘add’ message is removed properly.

    5. Navigate to the Search page and search for the employee you just added by first or last name.

    6. Search for an employee that does not exist.

    7. Demonstrate the remaining search capabilities: id, first name, last name, and anything else that you implemented.

  2. Step through your code, starting with the ApplicationStartUp, then take me through the Add scenario and the Search scenario.

Keep this around 10 minutes. Remember to use the correct Java terminology. Avoid using words like "this over here" or other vague phrasing. Be specific in your description of the flow and logic.

Part 2: Code Questions

Be prepared to answer the following questions about your project code. Answers must be different from a previous code review.

  1. Provide one example of how you debugged a problem in your Java code.

    1. Was it a compiler, runtime, or syntax error?
    2. What did you identify the source of your error?
    3. How did you solve the error?

  2. What Java Best Practices are used in your code?

  3. Identify an area of the project where a Programming Principle is used. How does it improve the code quality?

  4. Identify an OOP concept in the project and its purpose. How does it improve the code quality?

  5. What concrete implementations of the Collection interface did you use in this project? Why?

Code Review Tips

  • Reading this short article will help you understand some of specific issues we will focus on in the review.
  • Ask for clarification and/or help before your scheduled code review if you are stuck on any aspect of the project.

Rubric

All of the following must be satisfied to achieve a "Met" status

  • The flow and logic of the Java program is explained using correct Java terminology.
  • The explanation is clear, and concise.
  • At least one debugging example is shared including, the error type, source, and solution.
  • A Java Best Practice, Java Principle, and an OOP concept are identified and explained.
  • Identification and rational for using Java Collection classes.

Feedback

You are responsible for taking notes during the code review. Jot down any improvements, recommendations, and comments the instructor provides during the code review. There is a document in your projects directory under each project folder for taking notes: code-review-notes.md.

Additional feedback on the rubric items below, as well as the "Met" or "Not Met" mark, will be added to your project issue for you to review.

Making Corrections

  1. If your code review is at a "Not Yet" status, you can redo your code review in the form of a video.
  2. Keep the video under 20 minutes and send me the completed recording in Slack once complete.